Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPCP-6]: Make IconButton round. #5

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

angeloreale
Copy link
Contributor

@angeloreale angeloreale commented Jul 13, 2024

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

[DPCP-6]: Make IconButton round.

This PR makes design updates to the Button Atom (Icon variant).

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oneiros ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 8:56am

Copy link

Make IconButton round

@angeloreale
Copy link
Contributor Author

image

Copy link
Contributor Author

@angeloreale angeloreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@angeloreale angeloreale merged commit 03e41a6 into main Jul 13, 2024
6 checks passed
@angeloreale angeloreale deleted the ar/feat/dpcp-6--iconbutton-updates branch July 13, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant